Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-add multi to target session #352

Merged
merged 1 commit into from
May 6, 2022

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Apr 27, 2022

ref #305

After a period of online testing and use, we found that we needed to add back Multi

The current methods of sending messages can be divided into two main categories:

  1. sending with a specified id (Single, Multi)
  2. send all (All, Filter)

For multicast where the specified object is known, using Filter is a costly act and a full traversal of all connected nodes must be performed.

Filter is more suitable for behaviors where the specific target is not known, but the sending rules are known, such as gossip

Now there is one more problem, do we need to specify Vec or the more loose Box<dyn Iterator<Item = SessionId> + Send + 'static> as the type of Multi@TheWaWaR @quake

@driftluo driftluo requested a review from TheWaWaR as a code owner April 27, 2022 07:36
@driftluo driftluo merged commit fa50edc into master May 6, 2022
@driftluo driftluo deleted the readd-multi-to-target-session branch May 6, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants