feat: re-add multi to target session #352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #305
After a period of online testing and use, we found that we needed to add back
Multi
The current methods of sending messages can be divided into two main categories:
For multicast where the specified object is known, using
Filter
is a costly act and a full traversal of all connected nodes must be performed.Filter
is more suitable for behaviors where the specific target is not known, but the sending rules are known, such as gossipNow there is one more problem, do we need to specify
Vec
or the more looseBox<dyn Iterator<Item = SessionId> + Send + 'static>
as the type ofMulti
? @TheWaWaR @quake