feat: allow sha256 for HTLC #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
force-pushed
the
feature/tlc-hash-algo
branch
from
4dc7a1f
to
f1970c8
Compare
doitian
force-pushed
the
feature/tlc-hash-algo
branch
2 times, most recently
from
0ac8a30
to
42b65d6
Compare
|
Need time to add tests to cover SHA256 HTLC, but the code is ready for review. |
doitian
force-pushed
the
feature/tlc-hash-algo
branch
from
42b65d6
to
213e998
Compare
doitian
force-pushed
the
feature/tlc-hash-algo
branch
8 times, most recently
from
dcdd6a5
to
871095b
Compare
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6 - Added a field `hash_algorithm` when adding TLC - Save the `hash_algorithm` in the internal TLC struct - Check hash against preimage using the saved `hash_algorithm` - Added `hash_algorithm` in the invoice as a new attribute
doitian
force-pushed
the
feature/tlc-hash-algo
branch
from
871095b
to
b92895d
Compare
quake
approved these changes
Jun 28, 2024
contrun
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use sha256 in TLC.
See contract PR nervosnetwork/fiber-scripts#6
hash_algorithmwhen adding TLChash_algorithmin the internal TLC structhash_algorithmhash_algorithmin the invoice as a new attributeThe sha256 TLC is covered in the e2e test case 3-nodes-transfer with extra args
--env-var HASH_ALGORITHM=sha256