Remove anyhow's backtrace from RPC response #4728
Open
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
force-pushed
the
exec/remove-rpc-backtrace
branch
from
6c7a896
to
e11f007
Compare
eval-exec
force-pushed
the
exec/remove-rpc-backtrace
branch
2 times, most recently
from
9937739
to
544d4c8
Compare
doitian
previously approved these changes
Nov 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eval-exec
force-pushed
the
exec/remove-rpc-backtrace
branch
from
544d4c8
to
677ce79
Compare
chenyukang
reviewed
Nov 26, 2024
rpc/src/error.rs
Outdated
| .lines() | ||
| .take_while(|line| !line.starts_with("Stack backtrace:")) | ||
| .collect(); | ||
| lines.join("\n") |
There was a problem hiding this comment.
seems there will be an empty extra new line.
There was a problem hiding this comment.
Yes, that's true, but it's not a big deal.
chenyukang
previously approved these changes
Nov 26, 2024
quake
reviewed
Nov 26, 2024
rpc/src/error.rs
Outdated
| /// | ||
| /// # Returns | ||
| /// * A `String` containing the error message without the backtrace. | ||
| fn remove_backtrace(err_str: &str) -> String { |
There was a problem hiding this comment.
suggest to use find and return slice
fn remove_backtrace(err_str: &str) -> &str {
match err_str.find("\nStack backtrace:") {
Some(idx) => &err_str[..idx],
None => err_str,
}
}
677ce79
to
58df314
Compare
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/remove-rpc-backtrace
branch
from
58df314
to
2ae41ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4698
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Release note