Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4107 to rc/v0.111.x #4111

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Backport #4107 to rc/v0.111.x #4111

merged 1 commit into from
Aug 21, 2023

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Backport #4107 to rc/v0.111.x

Problem Summary:

When send a transaction with (outputs capacity) > (inputs capacity), Reject::Malformed(Overflow) error seems confused for user.

What is changed and how it works?

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 21, 2023 02:54
@zhangsoledad zhangsoledad merged commit 2c6ee9c into nervosnetwork:rc/v0.111.x Aug 21, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @zhangsoledad @eval-exec