Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport batch develop fix to 111 #4102

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
65c7bc5
test: make sure `2_in_2_out_rtx` will suspend on first run
eval-exec Jun 20, 2023
3955cff
chore: add `make docker-publish-rc`
doitian Jun 25, 2023
82b12d1
Fix bats tests failed for rc version like `ckb 0.111.0-rc6`
eval-exec Jun 29, 2023
00ff681
chore: add comment to header sync with empty
driftluo Jul 4, 2023
4bf0df1
Fix `hermit-abi` yanked
eval-exec Jul 5, 2023
37e8cf3
Fix relayer::request_proposal_txs dedup proposals
eval-exec Jul 5, 2023
ee0b414
deps: let `ckb-rpc` use `workspace.itertools`
eval-exec Jul 5, 2023
316e09e
feat(script): add peak_memory syscall
mohanson Jul 6, 2023
7fb2f2f
Rename peak_memory to current_memory
mohanson Jul 6, 2023
d6b3713
Fix bats test `ckb_run` should wait ckb process exit
eval-exec Jul 3, 2023
5323d3c
refactor(scripts): current_cycles returns the sum of cycles of all li…
mohanson Jul 5, 2023
3fd9de5
User more strict checking in spawn_callee_current_cycles
mohanson Jul 6, 2023
8bea079
chore(script): test case spawn_peak_memory_512k_to_32m
mohanson Jul 11, 2023
9cf92da
Update ckb to v0.24.2
mohanson Jul 11, 2023
2dc2516
deps(script): update ckb-vm to v0.24.3
mohanson Jul 17, 2023
920baf7
test(script): add check_spawn_times_bug test case
mohanson Jul 17, 2023
a632415
feat: add `register_thread` and `new_tokio_exit_rx`
eval-exec Jun 20, 2023
a64c2ff
test: add basic unit test for ckb shutdown
eval-exec Jun 20, 2023
2d6409c
wait all thread and tokio tasks exit before process exit
eval-exec Jun 20, 2023
daefd22
exit when `ProtocolHandleErrorKind::AbnormallyClosed` received
eval-exec Jun 20, 2023
5108122
Fix BlockDownload thread exit
eval-exec Jun 20, 2023
8358b26
Re-order ckb workspace members
eval-exec Jun 26, 2023
37f2482
Fix bats test for ckb run
eval-exec Jul 3, 2023
e95b8c7
Only catch exit signal for `ckb run`
eval-exec Jul 12, 2023
7012fba
Use debug level to print exit signal log
eval-exec Jul 12, 2023
c4aca9a
Add exit handler for `ckb miner`
eval-exec Jul 12, 2023
ba6a5df
Add bats test for graceful shutdown
eval-exec Jul 12, 2023
6936766
fix: set `TxPoolService.started` to `true` before `tx_pool_controller…
eval-exec Jul 18, 2023
437f13d
Add `winapi` dep to `dev-dependencies`
eval-exec Jul 18, 2023
142e4bf
Fix unit test: handle windows platform for signal-handle
eval-exec Jul 18, 2023
e019245
docs: Fix `PendingCompactBlockMap` comment
eval-exec Jul 17, 2023
9019a45
Remove stop-handler unit test for Windows platform
eval-exec Jul 18, 2023
75b05b2
docs: note the `send_transaction` is asynchronous
eval-exec Jul 18, 2023
ed2fb5f
docs: re-execute `make gen-rpc-doc`
eval-exec Jul 18, 2023
379b7ad
terminate process when nonce limit reached
chenyukang Jul 18, 2023
26764ce
Update ckb-vm to v0.24.4
mohanson Jul 21, 2023
932834b
chore: light client activation parameters
zhangsoledad Jul 28, 2023
769b681
add ctrl hander for test main
chenyukang Aug 2, 2023
ff0e470
fix the timeout issue in integeration main
chenyukang Aug 2, 2023
565d382
node start will not panic when child process crashed
chenyukang Aug 2, 2023
0dfb57f
Increase integration CI timeout to 2 hours
eval-exec Aug 4, 2023
a4468af
Print node Spec name when killed the node
eval-exec Aug 4, 2023
5f93396
fix: data2 value
zhangsoledad Aug 9, 2023
464c769
Fix `FeeOfMultipleMaxBlockProposalsLimit` failed
eval-exec Jul 20, 2023
0f5c770
Improve code comment
eval-exec Aug 14, 2023
b1530fc
fix typos in rpc readme.
EthanYuan Aug 15, 2023
07de5e9
fixing typos in comments
EthanYuan Aug 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 40 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ members = [
"util/occupied-capacity/macros",
"util/fixed-hash/macros",
"util/logger-service",
"util/stop-handler",
"util/runtime",
"util/stop-handler",
"util/metrics",
"util/metrics-service",
"util/fixed-hash",
Expand Down Expand Up @@ -93,6 +93,7 @@ members = [

[workspace.dependencies]
tempfile = "3"
itertools = "0.11.0"

[profile.release]
overflow-checks = true
Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ docker-publish:
docker tag nervos/ckb:$$(git describe) nervos/ckb:latest
docker push nervos/ckb:latest

.PHONY: docker-publish-rc
docker-publish-rc:
docker push nervos/ckb:$$(git describe)

##@ Code Quality
.PHONY: fmt
fmt: setup-ckb-test ## Check Rust source code format to keep to the same style.
Expand Down
3 changes: 1 addition & 2 deletions benches/benches/benchmarks/overall.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use ckb_chain_spec::consensus::{ConsensusBuilder, ProposalWindow};
use ckb_dao_utils::genesis_dao_data;
use ckb_jsonrpc_types::JsonBytes;
use ckb_launcher::SharedBuilder;
use ckb_network::{DefaultExitHandler, Flags, NetworkController, NetworkService, NetworkState};
use ckb_network::{Flags, NetworkController, NetworkService, NetworkState};
use ckb_shared::Shared;
use ckb_store::ChainStore;
use ckb_types::{
Expand Down Expand Up @@ -77,7 +77,6 @@ fn dummy_network(shared: &Shared) -> NetworkController {
"test".to_string(),
Flags::COMPATIBILITY,
),
DefaultExitHandler::default(),
)
.start(shared.async_handle())
.expect("Start network service failed")
Expand Down
14 changes: 8 additions & 6 deletions block-filter/src/filter.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use ckb_async_runtime::tokio::{self, sync::oneshot, task::block_in_place};
use ckb_async_runtime::tokio::{self, task::block_in_place};
use ckb_logger::{debug, warn};
use ckb_shared::Shared;
use ckb_stop_handler::{SignalSender, StopHandler};
use ckb_stop_handler::{new_tokio_exit_rx, CancellationToken};
use ckb_store::{ChainDB, ChainStore};
use ckb_types::{
core::HeaderView,
Expand Down Expand Up @@ -43,10 +43,10 @@ impl BlockFilter {
}

/// start background single-threaded service to create block filter data
pub fn start(self) -> StopHandler<()> {
pub fn start(self) {
let notify_controller = self.shared.notify_controller().clone();
let async_handle = self.shared.async_handle().clone();
let (stop, mut stop_rx) = oneshot::channel::<()>();
let stop_rx: CancellationToken = new_tokio_exit_rx();
let filter_data_builder = self.clone();

let build_filter_data =
Expand All @@ -62,12 +62,14 @@ impl BlockFilter {
block_in_place(|| self.build_filter_data());
new_block_watcher.borrow_and_update();
}
_ = &mut stop_rx => break,
_ = stop_rx.cancelled() => {
debug!("BlockFilter received exit signal, exit now");
break
},
else => break,
}
}
});
StopHandler::new(SignalSender::Tokio(stop), None, NAME.to_string())
}

/// build block filter data to the latest block
Expand Down
Loading
Loading