Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8, suggest 3.10 by default #3527

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SharkWipf
Copy link
Contributor

Python 3.8 is officially EOL, and at least one Nerfstudio dependency does not work with Python 3.8 anymore (#3461).
I've been running Nerfstudio on Python 3.10 myself without problems (although I've only tested on Linux). I remember having had problems in the past with some dependencies not yet supporting 3.11/3.12, but I don't know if that's been solved already. 3.10 seemed like the safest bet to target.
If you want to target a different python version by default, by all means, I just picked 3.10 because I knew that worked for me.

Reverts #3474 as it is no longer needed after this.

@brentyi
Copy link
Collaborator

brentyi commented Nov 18, 2024

@SharkWipf
Copy link
Contributor Author

Whoops, forgot about those, should be done now.

@SharkWipf
Copy link
Contributor Author

The Dockerfile is already using Python 3.10 it seems.

@SharkWipf
Copy link
Contributor Author

(Surely I've got them all now, right?)

@jb-ye
Copy link
Collaborator

jb-ye commented Nov 21, 2024

@SharkWipf also run ruff formatter

@SharkWipf
Copy link
Contributor Author

@jb-ye Done, but it only changed files I haven't touched at all, is that expected? Like, the issues ruff found were entirely unrelated to this PR.

@SharkWipf
Copy link
Contributor Author

Welp, guess the github workflow doesn't like python 3.10...

@SharkWipf
Copy link
Contributor Author

SharkWipf commented Nov 21, 2024

Hmm. So the only pyright error from CI that I can reproduce locally is the matplotlib colormap one. The rest don't happen when I run it locally, nor do I understand them.
As for the matplotlib error, it seems that with Python 3.8, matplotlib was stuck at version 3.7.3. On Python 3.10, it uses version 3.9.2.
Between these versions, apparently the matplotlib colormap code has been getting reworked.
I cannot find any documentation on matplotlib.colormaps even in the 3.7 documentation though. Was this even a public API to begin with? No matplotlib.colormaps seems to exist at all in the docs, which makes me think it was not an API that was ever meant to be used directly.
(Edit: Looks like it was introduced in #1894)

Unfortunately these issues seem to run deeper than I can quickly whip up a fix for without diving into what exactly is going on here, this is all foreign territory for me.
I've never run into any issues running Nerfstudio on Python 3.10 (or even 3.11) myself, but supposedly this has been an issue with any newer Python versions for a while.

What do you want to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants