-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8, suggest 3.10 by default #3527
base: main
Are you sure you want to change the base?
Conversation
…utomatic formatting fixes)
This sounds good to me, @SharkWipf do you mind also bumping the Python versions used for the GH Actions workflows? https://github.com/nerfstudio-project/nerfstudio/blob/main/.github/workflows/publish.yml |
Whoops, forgot about those, should be done now. |
The Dockerfile is already using Python 3.10 it seems. |
(Surely I've got them all now, right?) |
@SharkWipf also run ruff formatter |
@jb-ye Done, but it only changed files I haven't touched at all, is that expected? Like, the issues ruff found were entirely unrelated to this PR. |
Welp, guess the github workflow doesn't like python 3.10... |
Hmm. So the only pyright error from CI that I can reproduce locally is the matplotlib colormap one. The rest don't happen when I run it locally, nor do I understand them. Unfortunately these issues seem to run deeper than I can quickly whip up a fix for without diving into what exactly is going on here, this is all foreign territory for me. What do you want to do here? |
Python 3.8 is officially EOL, and at least one Nerfstudio dependency does not work with Python 3.8 anymore (#3461).
I've been running Nerfstudio on Python 3.10 myself without problems (although I've only tested on Linux). I remember having had problems in the past with some dependencies not yet supporting 3.11/3.12, but I don't know if that's been solved already. 3.10 seemed like the safest bet to target.
If you want to target a different python version by default, by all means, I just picked 3.10 because I knew that worked for me.
Reverts #3474 as it is no longer needed after this.