fixed threhsold charts (#48)

neptune-ai · Aug 22, 2019 · 4838a7e · 4838a7e
1 parent 434ecab
commit 4838a7e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/docs/conf.py b/docs/conf.py
@@ -48,7 +48,7 @@
 # The short X.Y version
 version = '0.12'
 # The full version, including alpha/beta/rc tags
-release = '0.12.2'
+release = '0.12.3'
 
 # -- General configuration ---------------------------------------------------
 

diff --git a/neptunecontrib/monitoring/metrics.py b/neptunecontrib/monitoring/metrics.py
@@ -794,7 +794,10 @@ def _class_metrics_by_threshold(y_true, y_pred_pos, thres_nr=100):
 
 
 def _get_best_thres(scores_by_thres, name):
-    best_res = scores_by_thres[scores_by_thres[name] == scores_by_thres[name].max()][['threshold', name]]
+    if name in ['false_positive_rate', 'false_negative_rate', 'false_discovery_rate']:
+        best_res = scores_by_thres[scores_by_thres[name] == scores_by_thres[name].min()][['threshold', name]]
+    else:
+        best_res = scores_by_thres[scores_by_thres[name] == scores_by_thres[name].max()][['threshold', name]]
     position = len(best_res) // 2
     result = best_res.iloc[position].to_dict()
     return result['threshold'], result[name]
diff --git a/setup.py b/setup.py
@@ -20,7 +20,7 @@ def main():
 
     setup(
         name='neptune-contrib',
-        version='0.12.2',
+        version='0.12.3',
         description='Neptune Python library contributions',
         author='neptune.ml',
         author_email='[email protected]',