Fix race condition between close and flush in disk queue (#1470)

neptune-ai · Sep 18, 2023 · 8fa3ebc · 8fa3ebc
1 parent ee0f099
commit 8fa3ebc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@
 
 ### Fixes
 - Fix exception handling in `ApiMethodWrapper.handle_neptune_http_errors` ([#1469](https://github.com/neptune-ai/neptune-client/pull/1469))
-
+- Fix race condition between close and flush in disk queue ([#1470](https://github.com/neptune-ai/neptune-client/pull/1470))
 
 ## neptune 1.6.3
 

diff --git a/src/neptune/internal/disk_queue.py b/src/neptune/internal/disk_queue.py
@@ -92,9 +92,10 @@ def put(self, obj: T) -> int:
         version = self._last_put_file.read_local() + 1
         _json = json.dumps(self._serialize(obj, version))
         if self._file_size + len(_json) > self._max_file_size:
-            self._writer.flush()
-            self._writer.close()
+            old_writer = self._writer
             self._writer = open(self._get_log_file(version), "a")
+            old_writer.flush()
+            old_writer.close()
             self._file_size = 0
             self._write_file_version = version
         self._writer.write(_json + "\n")