retry 408 and 429 statuses in legacy client (#829)

* retry 408 and 429 statuses in legacy client * changelog * more consistency in catching exceptions * fix duplicate handling
neptune-ai · Jan 20, 2022 · 620b126 · 620b126
1 parent ff3d394
commit 620b126
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 
 ## Fixes
 - Raise proper exception when invalid token were provided ([#825](https://github.com/neptune-ai/neptune-client/pull/825))
+- Make status error-handling in legacy client consistent with neptune.new ([#829](https://github.com/neptune-ai/neptune-client/pull/829))
 
 ## neptune-client 0.14.2
 

diff --git a/neptune/utils.py b/neptune/utils.py
@@ -42,7 +42,9 @@
     HTTPServerError,
     HTTPServiceUnavailable,
     HTTPUnauthorized,
+    HTTPTooManyRequests,
 )
+from urllib3.exceptions import NewConnectionError
 
 from neptune import envs
 from neptune.api_exceptions import (
@@ -324,6 +326,9 @@ def wrapper(*args, **kwargs):
                 HTTPRequestTimeout,
                 HTTPGatewayTimeout,
                 HTTPBadGateway,
+                HTTPTooManyRequests,
+                HTTPServerError,
+                NewConnectionError,
             ):
                 if retry >= 6:
                     _logger.warning(
@@ -332,8 +337,6 @@ def wrapper(*args, **kwargs):
                 time.sleep(2 ** retry)
                 retry += 1
                 continue
-            except HTTPServerError:
-                raise ServerError()
             except HTTPUnauthorized:
                 raise Unauthorized()
             except HTTPForbidden:
@@ -357,9 +360,12 @@ def wrapper(*args, **kwargs):
                     time.sleep(2 ** retry)
                     continue
                 elif status_code in (
+                    HTTPRequestTimeout.status_code,
                     HTTPBadGateway.status_code,
                     HTTPServiceUnavailable.status_code,
                     HTTPGatewayTimeout.status_code,
+                    HTTPTooManyRequests.status_code,
+                    HTTPServerError.status_code,
                 ):
                     if retry >= 6:
                         _logger.warning(