Skip to content

Commit

Permalink
Validate model key and fix error handling (#896)
Browse files Browse the repository at this point in the history
* Validate model key and fix error handling

* Fix

* Add commment

* Fix

* Fix

* Changelog
  • Loading branch information
aniezurawski authored May 12, 2022
1 parent 806d76d commit 4b164bc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
## [UNRELEASED] neptune-client 0.16.2
## [UNRELEASED] neptune-client 0.16.3


## neptune-client 0.16.2

## Features
- Sync only offline runs inside '.neptune' directory CLI flag ([#894](https://github.com/neptune-ai/neptune-client/pull/894))

## Fixes
- Fix handling of server errors ([#896](https://github.com/neptune-ai/neptune-client/pull/896))

## neptune-client 0.16.1

## Features
Expand Down
2 changes: 2 additions & 0 deletions neptune/new/internal/backends/hosted_neptune_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ def create_run(
additional_params=additional_params,
)

@with_api_exceptions_handler
def create_model(self, project_id: UniqueId, key: str = "") -> ApiExperiment:
additional_params = {
"key": key,
Expand All @@ -374,6 +375,7 @@ def create_model(self, project_id: UniqueId, key: str = "") -> ApiExperiment:
additional_params=additional_params,
)

@with_api_exceptions_handler
def create_model_version(
self, project_id: UniqueId, model_id: UniqueId
) -> ApiExperiment:
Expand Down

0 comments on commit 4b164bc

Please sign in to comment.