Skip to content

Commit

Permalink
Code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Raalsky committed Apr 8, 2024
1 parent 5f93c92 commit 157f8e4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
8 changes: 4 additions & 4 deletions src/neptune/api/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def from_model(model: Any) -> FileSetField:
class FloatSeriesField(Field, field_type=FieldType.FLOAT_SERIES):
last: Optional[float]

def accept(self, visitor: "FieldVisitor[Ret]") -> Ret:
def accept(self, visitor: FieldVisitor[Ret]) -> Ret:
return visitor.visit_float_series(self)

@staticmethod
Expand All @@ -309,7 +309,7 @@ def from_model(model: Any) -> FloatSeriesField:
class StringSeriesField(Field, field_type=FieldType.STRING_SERIES):
last: Optional[str]

def accept(self, visitor: "FieldVisitor[Ret]") -> Ret:
def accept(self, visitor: FieldVisitor[Ret]) -> Ret:
return visitor.visit_string_series(self)

@staticmethod
Expand All @@ -326,7 +326,7 @@ def from_model(model: Any) -> StringSeriesField:
class ImageSeriesField(Field, field_type=FieldType.IMAGE_SERIES):
last_step: Optional[float]

def accept(self, visitor: "FieldVisitor[Ret]") -> Ret:
def accept(self, visitor: FieldVisitor[Ret]) -> Ret:
return visitor.visit_image_series(self)

@staticmethod
Expand All @@ -343,7 +343,7 @@ def from_model(model: Any) -> ImageSeriesField:
class StringSetField(Field, field_type=FieldType.STRING_SET):
values: Set[str]

def accept(self, visitor: "FieldVisitor[Ret]") -> Ret:
def accept(self, visitor: FieldVisitor[Ret]) -> Ret:
return visitor.visit_string_set(self)

@staticmethod
Expand Down
9 changes: 0 additions & 9 deletions src/neptune/internal/backends/hosted_neptune_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,6 @@
FieldType.OBJECT_STATE.value,
}

ATOMIC_ATTRIBUTE_TYPES = {
FieldType.INT.value,
FieldType.FLOAT.value,
FieldType.STRING.value,
FieldType.BOOL.value,
FieldType.DATETIME.value,
FieldType.OBJECT_STATE.value,
}


class HostedNeptuneBackend(NeptuneBackend):
def __init__(self, credentials: Credentials, proxies: Optional[Dict[str, str]] = None):
Expand Down

0 comments on commit 157f8e4

Please sign in to comment.