Sync with original repository #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To request explicitly the minimum required permissions for this action to GitHub Actions, this adds "permissions" field to the example of job definition. This does not request users to make their default setting permisssive.
This can happen when the offense is in rubocop cache or in parallel mode
Avoid nil pointer exception with correctable offense without corrector
README: Add "permissions" field to example of usage
This PR is fx an indentation for script.sh
Change `original_output`, adding file. The field is printed by reviewdog on running the action with github-pr-review reporter. Before, it did not contain file, thus messages were not fully informative. E.g. ``` C: 30: 54: Rails/AttributeDefaultBlockValue: Pass method in a block to `:default` option. ``` This change fixes the field, adding file: ``` app/models/user.rb:30:54: C: Rails/AttributeDefaultBlockValue: Pass method in a block to `:default` option. ```
Fix an indentation for script.sh
Change `original_output` in `RdjsonFormatter`, adding file
RuboCop's severity levels are represented by RuboCop::Cop::Severity obejcts, not symbols. Internally, this objects holds a symbol in its `name` attribute an implements comparison methods. Sadly, these comparisons aren't reversable: `severity === :info => true`, but `:info === severity => false`. The ruby case statement performs tripple-equals comparisons with the argument to the `when` clause as the first operand, so the existing case statement always returned `UNKNOWN_SEVERITY`.
Fix severity conversion; calculate overall severity based on RuboCop fail level
Update actions/checkout
Update peter-evans/create-pull-request
chore(deps): update reviewdog to 0.14.2
ci: replace 'create-release action' with gh cli
bump actions/checkout v4
chore(deps): update reviewdog to 0.15.0
chore(deps): update reviewdog to 0.17.1
Since Rubocop has multiple gems, it's best to rely on Bundler to install them rather than not. Other popular gems like Rails use this same feature to optimize their rubocop workflows. https://github.com/rails/rails/blob/main/.github/workflows/rubocop.yml
chore(deps): update reviewdog to 0.17.2
chore(deps): update reviewdog to 0.17.3
chore(deps): update reviewdog to 0.17.4
Fix relative_path_from error with old ruby 2.5.x
version function is not used since 06c2574
* order inputs alphabetically * add a comment requesting to keep alphabetical order * Better wording in comments requesting to maintain alphabetical order of inputs Co-authored-by: Javier Julio <[email protected]> --------- Co-authored-by: Javier Julio <[email protected]>
Co-authored-by: review-dog <[email protected]>
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.5...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: review-dog <[email protected]>
Co-authored-by: review-dog <[email protected]>
Co-authored-by: review-dog <[email protected]>
Co-authored-by: review-dog <[email protected]>
* add only_changed input to run rubocop only against changed files Switch to bash for process substitution and working with arrays. Ignore if there are more than 100. Protecting from possibly hitting the command line length limit, it can be much higher and can be calculated or also extracted as one more input if needed. The effect from limiting number of files processed by rubocop is also smaller. Fix ci workflow to fetch all commits for pr branch plus head commit of base branch to be able to find changed files. Co-authored-by: Oliver Günther <[email protected]> * automatically fetch the tip of the base branch if it is not available * don't hide the name of the CI job * test only_changed --------- Co-authored-by: Oliver Günther <[email protected]>
Co-authored-by: review-dog <[email protected]>
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.2 to 3.3.3. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.2...v3.3.3) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Since PR #103 introduced the default --fail-level flag, the severity level has become unchangeable due to this modification. Ideally, this flag (and others) should be overridable, but the RuboCop command prioritizes the flags that are specified last. This commit moves the user-specified flags to the end of the hard-coded flags, allowing them to be overridden. Signed-off-by: moznion <[email protected]>
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.3 to 3.3.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.3...v3.3.6) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: review-dog <[email protected]>
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.6...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… fail-on-error reviewdog flag (#124) * Replace deprecated fail-on-error flag with fail-level * Restore fail-on-error flag * Update doc with suggestions
Co-authored-by: review-dog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.