Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default_auto_field in AppConfig #182

Merged

Conversation

protoroto
Copy link
Member

Description

Set default_auto_field in AppConfig to avoid migrations problem if DEFAULT_AUTO_FIELD is different

References

Fix #181

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto protoroto changed the title Set default_auto_field in AppConfig to avoid migrations problem if DE… Set default_auto_field in AppConfig Sep 26, 2023
@coveralls
Copy link

coveralls commented Sep 26, 2023

Coverage Status

coverage: 94.634% (+0.01%) from 94.621% when pulling 1014939 on protoroto:bugfix/issue-181-set-default-auto-field into 43eb914 on nephila:develop.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (43eb914) 91.19% compared to head (1014939) 91.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
+ Coverage    91.19%   91.21%   +0.02%     
===========================================
  Files            9        9              
  Lines          409      410       +1     
  Branches        61       61              
===========================================
+ Hits           373      374       +1     
  Misses          22       22              
  Partials        14       14              
Flag Coverage Δ
unittests 91.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
djangocms_page_meta/apps.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto force-pushed the bugfix/issue-181-set-default-auto-field branch from 5f79431 to 1014939 Compare September 26, 2023 13:04
@protoroto protoroto requested a review from yakky September 26, 2023 13:04
@protoroto protoroto merged commit dfb30cf into nephila:develop Sep 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lock auto_field for IDs with AppConfig.default_auto_field
3 participants