Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update version of dep. "filer" 1.2 → 3.0 #175

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

wesleyboar
Copy link
Contributor

@wesleyboar wesleyboar commented Sep 19, 2023

Description

  • Update dependency Filer from v1.2+ to v3.0+
  • Prevents error from DjangoCMS Page Meta migration using unavailable Filer migration

References

Fix #173

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint1
  • changes file included (see docs)
  • Usage documentation added in case of new features2
  • Tests added2
tox output summary
  black: OK (0.42=setup[0.02]+cmd[0.39] seconds)
  blacken: OK (0.13=setup[0.00]+cmd[0.12] seconds)
  docs: OK (1.21=setup[0.01]+cmd[1.20] seconds)
  isort: OK (0.12=setup[0.00]+cmd[0.12] seconds)
  isort_format: OK (0.13=setup[0.00]+cmd[0.12] seconds)
  ruff: OK (0.14=setup[0.00]+cmd[0.04,0.10] seconds)
  pypi-description: OK (21.03=setup[0.01]+cmd[0.28,13.29,7.26,0.20] seconds)
  towncrier: OK (0.11=setup[0.00]+cmd[0.11] seconds)
  py311-django42-cms311: OK (5.35=setup[1.85]+cmd[3.50] seconds)
  py311-django41-cms311: OK (5.21=setup[1.71]+cmd[3.50] seconds)
  py310-django42-cms311: SKIP (0.25 seconds)
  py310-django41-cms311: SKIP (0.00 seconds)
  py39-django42-cms311: OK (8.43=setup[2.46]+cmd[5.97] seconds)
  py39-django41-cms311: OK (27.03=setup[21.14]+cmd[5.90] seconds)
  py311-django32-cms311: OK (19.84=setup[15.53]+cmd[4.32] seconds)
  py311-django32-cms39: OK (19.93=setup[15.46]+cmd[4.48] seconds)
  py310-django32-cms311: SKIP (0.00 seconds)
  py310-django32-cms39: SKIP (0.00 seconds)
  py39-django32-cms311: OK (25.12=setup[18.82]+cmd[6.30] seconds)
  py39-django32-cms39: OK (25.23=setup[17.32]+cmd[7.91] seconds)
  congratulations :) (159.73 seconds)

Footnotes

  1. I did pip install -r requirements-test.txt and pip install -e ., but when I ran inv lint, the output was zsh: command not found: inv. Consider expanding on this instruction… for noobs like me.

  2. Seemed irrelevant to the change. 2

@wesleyboar wesleyboar marked this pull request as ready for review September 19, 2023 21:53
@protoroto
Copy link
Member

@wesleyboar Thank you very much for this pr! I'll hope to merge this as soon as possible and release 1.4.1

@protoroto protoroto self-requested a review September 20, 2023 06:57
@protoroto protoroto force-pushed the bugfix/173-filer-update branch from 9aa91c2 to afaf150 Compare September 20, 2023 07:05
@coveralls
Copy link

Coverage Status

coverage: 94.621%. remained the same when pulling afaf150 on wesleyboar:bugfix/173-filer-update into f95f059 on nephila:develop.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f95f059) 91.19% compared to head (afaf150) 91.19%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #175   +/-   ##
========================================
  Coverage    91.19%   91.19%           
========================================
  Files            9        9           
  Lines          409      409           
  Branches        61       61           
========================================
  Hits           373      373           
  Misses          22       22           
  Partials        14       14           
Flag Coverage Δ
unittests 91.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto merged commit ccf319e into nephila:develop Sep 20, 2023
20 checks passed
protoroto pushed a commit that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filer Dependency Inccurate
3 participants