Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Run acceptance tests also on chrome #3862

Closed
wants to merge 6 commits into from

Conversation

markusguenther
Copy link
Member

No description provided.

platformName: "Windows 10"
screenResolution: "1280x1024"
- name: "One dimensional Tests in Edge on MacOS"
browserName: "microsoftedge"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not chrome? ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a try, in safari we also have issues in the tests ;)

@@ -3,7 +3,7 @@ kind: testcafe
sauce:
region: us-west-1
concurrency: 1 # Controls how many suites are executed at the same time.
retries: 0
retries: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retries / smart retries dont work as far as i tried.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing the PR for 8.4 I had the case that one run failed and the retry succeeded. But did not enforce it after that.

@@ -40,20 +40,6 @@ const SETTINGS_WITH_NODE_TREE_PRESETS = {
presets: {
'default': {
baseNodeType: 'Neos.Neos:Document,!Neos.TestNodeTypes:Document.Blog,!Neos.TestNodeTypes:Document.BlogArticle'
},
'blog': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should try to keep it and make it work on chrome. I dont know why it doesnt work in ci. Locally it works splendidly. We have to debug the http request

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the issue also locally, and therefore I changed this and also did not see why we need to change it. But I was not involved in the change back then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants