WIP: HACK: 90 edit preview mode support #3411
Conversation
|
currently breaks other plugins like: https://github.com/sandstorm/MxGraph/blob/6e1b14bc63bdeb84effea2a687471e209db610b6/Resources/Private/JavaScript/MxGraph/src/DiagramEditor.js#L15-L29 as
|
|
Currently the review is triggered very often on the ui side |
| @@ -44,7 +44,8 @@ export function * watchStopLoading({globalRegistry, store}) { | |||
| export function * watchReload() { | |||
| yield takeLatest(actionTypes.UI.ContentCanvas.RELOAD, function * (action) { | |||
There was a problem hiding this comment.
idk but why is there no reducer of actionTypes.UI.ContentCanvas.RELOAD which updates the current iframe url (if in payload)
then we can use the same selector down in line 61 ... or we can put into the selector a modified temporal state ...
|
What's the state of this one? Is it still being worked on, @mhsdesign ? |
|
currently untouched since dresden sprint. i dont know how neos/neos-development-collection#4067 moved forward and what was discussed in berlin about it (i have the feeling things were discussed in this direction). but feel free to sign me up for a sync meeting about it ^^ |
|
Main change is that we switched to separate edit and preview actions and decide on the rendering-mode by looking at the main request. Once this is accepted in neos/neos-development-collection#4067 it makes sense to proceed here. |
| @@ -55,7 +56,23 @@ export function * watchReload() { | |||
| // If the new uri is provided in the action payload, use that | |||
| // | |||
| if (iframeWindow.location.href === currentIframeUrl) { | |||
| iframeWindow.location.href = uri || iframeWindow.location.href; | |||
| if (uri) { | |||
| const state = yield select(); | |||
There was a problem hiding this comment.
as @grebaldi noted, yield is not allowed here and we have to get the state above / or convert it to a for of loop.
|
Close as outdated |
companion piece of neos/neos-development-collection#4067
@grebaldi what should i do im scared
What I did
How I did it
How to verify it
todo:
revert ce395ca once #3569 is merged