4622 - Catch view render results of unsupported type

neos · Oct 30, 2023 · 1e49246 · 1e49246
1 parent 08841c1
commit 1e49246
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Classes/Domain/Model/Feedback/Operations/ReloadContentOutOfBand.php b/Classes/Domain/Model/Feedback/Operations/ReloadContentOutOfBand.php
@@ -147,7 +147,11 @@ protected function renderContent(ControllerContext $controllerContext): string|R
                 $view->assign('value', $this->node);
                 $view->setRenderingEntryPoint($this->nodeDomAddress->getFusionPathForContentRendering());
 
-                return $view->render();
+                $result = $view->render();
+
+                return (is_string($result) || $result instanceof ResponseInterface)
+                    ? $result
+                    : '';
             }
         }
 

diff --git a/Classes/Domain/Model/Feedback/Operations/RenderContentOutOfBand.php b/Classes/Domain/Model/Feedback/Operations/RenderContentOutOfBand.php
@@ -196,7 +196,11 @@ protected function renderContent(ControllerContext $controllerContext): string|R
                 $view->assign('value', $parentNode);
                 $view->setRenderingEntryPoint($parentDomAddress->getFusionPath());
 
-                return $view->render();
+                $result = $view->render();
+
+                return (is_string($result) || $result instanceof ResponseInterface)
+                    ? $result
+                    : '';
             }
         }