Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Introduce ContentRepository::getNodeType to simplify 80% use #5329

Draft
wants to merge 2 commits into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

$contentRepository->getNodeTypeManager()->getNodeType() will be aliased as $contentRepository->getNodeType() to make the 90% usecase easy ... basically the same we are doing for getContentSubgraph() and findWorkspaceByName()

that way we probably dont need a higher level utility as fetching the cr would be just enough see #5065

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

`$contentRepository->getNodeTypeManager()->getNodeType()` will be aliased as `$contentRepository->getNodeType()` to make the 90% usecase easy ... basically the same we are doing for `getContentSubgraph()` and `findWorkspaceByName()`
@kitsunet
Copy link
Member

Yes nice idea, but I would say passing through methods from dependencies is very bad API design, I am opposed to this change.

@mhsdesign mhsdesign marked this pull request as draft October 28, 2024 13:26
@mhsdesign
Copy link
Member Author

thanks for the quick feedback, i did it just to have something concrete to discuss, as we often came to the need of some higher level api to make things simpler and instead i thought why not make the low level thing more fun :D

(#5065)

but we can easily discuss that also for Neos 9.1 or later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants