BUGFIX: Flush cache also for deleted nodes #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Jun 4, 2024
| @@ -159,7 +159,7 @@ protected function registerAllTagsToFlushForNodeInWorkspace(NodeInterface $node, | |||
| { | |||
| // Ensure that we're dealing with the variant of the given node that actually | |||
| // lives in the given workspace | |||
| if ($node->getWorkspace()->getName() !== $workspace->getName()) { | |||
| if ($node->isRemoved() === false && $node->getWorkspace()->getName() !== $workspace->getName()) { | |||
| $workspaceContext = $this->contextFactory->create( | |||
| array_merge( | |||
| $node->getContext()->getProperties(), | |||
There was a problem hiding this comment.
or should we use showRemovedNodes in the context or something?
fyi will also run the neos e2e tests against this soon
There was a problem hiding this comment.
This is not working, I also tried that.
mhsdesign
approved these changes
Jun 4, 2024
grebaldi
approved these changes
Jun 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed nodes can't get found, so they regarding caches don't get flushed.
The bug was introduced with #4291
Fixes: #5105