Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: move user menu to left drawer #4934

Merged
merged 5 commits into from
Mar 14, 2024
Merged

FEATURE: move user menu to left drawer #4934

merged 5 commits into from
Mar 14, 2024

Conversation

laurahaenel
Copy link
Collaborator

@laurahaenel laurahaenel commented Mar 12, 2024 •
edited
Loading

I moved the user menu to the left drawer to free space in the primary toolbar.

  • Move the UserMenu Component to the left drawer
  • Rearrange the order of the dropdown items
  • Add a new UserImage Component that currently renders the users initials
  • Styling

Upgrade instructions

Review instructions

image

Related issues: #4825 neos/neos-ui#3685

Neos.UI PR: neos/neos-ui#3740

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@laurahaenel laurahaenel marked this pull request as ready for review March 13, 2024 09:22
@laurahaenel
Copy link
Collaborator Author

This change is affected by the open bug #4590

dlubitz
dlubitz approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me by reading! Thank you!

@dlubitz dlubitz linked an issue Mar 13, 2024 that may be closed by this pull request
FEATURE: Relocate User Menu to the Left Drawer #4825
Closed
1 task
@laurahaenel laurahaenel mentioned this pull request Mar 14, 2024
Merged
@ahaeslich
Copy link
Member

Greate work 💖

@ahaeslich ahaeslich merged commit 991ab77 into neos:9.0 Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@ahaeslich ahaeslich ahaeslich approved these changes

Assignees
No one assigned
Labels
9.0 Feature
Projects
No open projects
Neos Sprint Hamburg - 2024-03
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: Relocate User Menu to the Left Drawer
3 participants
@laurahaenel @ahaeslich @dlubitz