Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use renderingMode.isEdit in NodeController #4874

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 6, 2024

Followup to #4505
Followup to #4733

Resolves partially #4396

we want to avoid calling $nodeAddress->isInLiveWorkspace() and use the rendering mode instead as this reflects more accurate the users intention.

this change also documents clearly that shortcut nodes are only to be resolved for live workspaces.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign changed the title TASK: RenderingMode followup TASK: Use renderingMode.isEdit in NodeController Feb 6, 2024
@mhsdesign mhsdesign merged commit 10fbb8b into neos:9.0 Feb 7, 2024
10 checks passed
@mhsdesign mhsdesign deleted the task/renderingModeFollowup branch February 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants