TASK: Remove Neos.Node.inBackend() and Neos.Node.isLive() eel helper
#4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahaeslich
reviewed
Sep 20, 2023
mhsdesign
requested changes
Sep 20, 2023
|
... and if we remove |
It was deprecated in #4505 in favor of `${userInterfaceMode.isEdit}`. Since the ui is adjusted in neos/neos-ui#3618 it can now be removed.
mficzel
force-pushed
the
90-removeNodeInBackendHelper
branch
from
68efe66 to
41651f6
Compare
mhsdesign
approved these changes
Sep 20, 2023
ahaeslich
changed the title
Neos.Node.inBackend() eel helper
ahaeslich
approved these changes
Sep 21, 2023
mhsdesign
changed the title
Neos.Node.inBackend() and Neos.Node.isLive() eel helper
ahaeslich
added a commit
that referenced
this pull request
Sep 21, 2023
6 tasks
|
Ah forgot that @mficzel already adjusted the rector migrations in neos/rector#22 🤦 I did adjust Neos.Seo where we introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was deprecated in #4505 in favor of
${renderingMode.isEdit}. Since the ui is adjusted in neos/neos-ui#3618 it can now be removed.Relates: #4086
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions