Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Task rename Neos.Neos WorkspaceName to NeosWorkspaceName #4529

Closed
wants to merge 1 commit into from
Closed

TASK: Task rename Neos.Neos WorkspaceName to NeosWorkspaceName #4529

wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 18, 2023 •
edited
Loading

This will make it easier to import the correct Neos CR WorkspaceName - which one will want to use more likely.

Resolves partially #4341

Neos Ui part: neos/neos-ui#3623

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
TASK: Task rename Neos.Neos WorkspaceName to NeosWorkspaceName
307a83c 
This will make it easier to import the correct Neos CR WorkspaceName - which one will want to use more likely.

Resolves partially #4341
mhsdesign added a commit to neos/neos-ui that referenced this pull request Sep 18, 2023
@mhsdesign
TASK: Adjust naming to NeosWorkspaceName
73cba59 
see neos/neos-development-collection#4529
@mhsdesign mhsdesign mentioned this pull request Sep 18, 2023
Closed
@bwaidelich bwaidelich self-assigned this Sep 19, 2023
@bwaidelich
Copy link
Member

as discussed in todays team meeting: I'll try to remove the NeosWorkspaceName in favor of some factory

@bwaidelich bwaidelich mentioned this pull request Sep 19, 2023
Merged
6 tasks
@bwaidelich
Copy link
Member

Closing in favor of #4534

@bwaidelich bwaidelich closed this Sep 19, 2023
@mhsdesign mhsdesign deleted the task/renameNeosWorkspaceName branch September 19, 2023 11:14
@mhsdesign mhsdesign mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bwaidelich bwaidelich

Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @bwaidelich