Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! TASK: Cleanup deprecated code in FusionService #4496

Merged
merged 1 commit into from
Sep 19, 2023
Merged

!!! TASK: Cleanup deprecated code in FusionService #4496

merged 1 commit into from
Sep 19, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 10, 2023 •
edited
Loading

Upgrade instructions

With #3839 the FusionService was refactored and weird/hardly usable functionally removed. The legacy parts will be removed in this pr.

FusionService:: getMergedFusionObjectTree was removed in favour of FusionService:: createFusionConfigurationFromSite

In case you used any of the setter methods like setAppendFusionIncludes to add additional Fusion includes to the configuration, you should instead build an own service like Monocle did, leveraging the FusionSourceCodeFactory: https://github.com/sitegeist/Sitegeist.Monocle/blob/b20da738e2999d66b6e2d10c901d7b1d7b540fc0/Classes/Fusion/FusionService.php#L67

Resolves #4089

Review instructions

related to #4495

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Sep 10, 2023
@mhsdesign mhsdesign mentioned this pull request Sep 11, 2023
Closed
6 tasks
@mhsdesign mhsdesign mentioned this pull request Sep 11, 2023
Open
7 tasks
kdambekalns
kdambekalns approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

bwaidelich
bwaidelich approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mhsdesign mhsdesign force-pushed the task/4089-cleanupFusionService branch from 05f3c68 to 830b200 Compare September 19, 2023 11:34
@mhsdesign mhsdesign force-pushed the task/4089-cleanupFusionService branch from 830b200 to 2621550 Compare September 19, 2023 11:35
mficzel
mficzel approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine be 👀 and testing. Thanks for cleaning up.

@mhsdesign mhsdesign merged commit 15be5b7 into 9.0 Sep 19, 2023
@mhsdesign mhsdesign deleted the task/4089-cleanupFusionService branch September 19, 2023 18:51
mhsdesign added a commit that referenced this pull request Oct 16, 2024
@mhsdesign
TASK: remove comment in FusionService
950f805 
Followup to #4496
neos-bot pushed a commit to neos/neos that referenced this pull request Oct 18, 2024
@mhsdesign
TASK: remove comment in FusionService
972c4f7 
Followup to neos/neos-development-collection#4496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mficzel mficzel mficzel approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@kdambekalns kdambekalns kdambekalns approved these changes

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

@kitsunet kitsunet Awaiting requested review from kitsunet

@skurfuerst skurfuerst Awaiting requested review from skurfuerst

Assignees
No one assigned
Labels
9.0beta1 9.0
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9.0: TASK: FusionService cleanup old API
4 participants
@mhsdesign @kdambekalns @bwaidelich @mficzel