BUGFIX: (Neos.Neos) Restore show action of ContentDimensionsController
#4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
grebaldi
added a commit
to neos/neos-ui
that referenced
this pull request
Jul 10, 2023
This includes the replacement of the 2Dimension site export with an equivalent ESCR event export. Also, as a temporary fix, neos/neos-development-collection#4395 was added as a patch.
grebaldi
force-pushed
the
bugfix/content-dimensions-controller-show-action
branch
from
0ac6b71 to
544775e
Compare
grebaldi
added a commit
to neos/neos-ui
that referenced
this pull request
Jul 12, 2023
grebaldi
force-pushed
the
bugfix/content-dimensions-controller-show-action
branch
from
544775e to
bc110df
Compare
mhsdesign
reviewed
Jul 12, 2023
ahaeslich
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The
showendpoint for content dimensions has been removed via #3848.The UI relies on that endpoint to populate the
<DimensionSelector/>with plausible values. Without the endpoint it breaks down:The solution
I restored the endpoint as far as possible, keeping the necessary semantics required by the UI.
I believe this will only serve as a temporary solution, because this particular concern should be handled inside the UI package.