!!!FEATURE: (Neos.Neos) Track created nodes in PendingChangesProjection #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
grebaldi
added a commit
to neos/neos-ui
that referenced
this pull request
Jul 8, 2023
Using the `PendingChangesProjection` from Neos.Neos, which after neos/neos-development-collection#4393 will track all nodes that have been newly created within the workspace that contains the change set that is being discarded.
In Neos.Neos/Classes/PendingChangesProjection/ChangeProjection.php: This moves most of the repeated code from the methods `markAsChanged`, `markAsCreated` and `markAsMoved` into a unified `modifyChange` method that accepts a callback for the aforementioned methods to perform their unique tasks in.
mhsdesign
requested review from
skurfuerst,
bwaidelich,
mficzel,
ahaeslich,
dlubitz and
mhsdesign
|
Sorry for the long delay. On the first sight, this looks good to me :) I'd suggest that we discuss it in an upcoming weekly, and then IMHO it is likely this can be merged! All the best, |
…nodes-in-change-projection
|
I just merged origin/9.0 here into this branch and fixed the conflicts (I hope correctly :) @grebaldi do you want to have a look again as well?) When the CI is green, IMHO this is merge ready. All the best, |
skurfuerst
approved these changes
Aug 2, 2023
grebaldi
added a commit
to neos/neos-ui
that referenced
this pull request
Aug 2, 2023
…395 from TestDistribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4024
This is an attempt to fix an issue that came up with neos/neos-ui#3569.
The E2E Tests for the UI try to discard a document that has just been created (without having been published) and that the user is currently viewing. When this happens, it is expected that the user will be redirected to the next-best document that can be viewed.
Instead, the UI failed to update the page tree and reloaded the guest frame, which then showed an error message of the form:
@ahaeslich had pointed me via Slack to #4024, where she had described this very behavior.
Looking into it, I had found that the UI simply had no idea which nodes have been removed through the discard-operation.
I then found the PendingChangesProjection mechanism here in Neos.Neos. I modified the projection to track every node that has been created within a workspace.
neos/neos-ui@f692333 (or more concretely: https://github.com/neos/neos-ui/blob/f6923332edf5a125ab42ac9c56500b6604e0c1d1/Classes/ContentRepository/Service/WorkspaceService.php#L159-L204) shows how that information is used to retrieve the nodes that have been removed through discard.
I'm new to the projection business, so I have no idea if what I came up here is any good. I'm looking forward to your reviews :)