Merge pull request #4881 from mhsdesign/task/removeNodeSubjectProvider

TASK: Declare `NodeSubjectProvider` as internal/wip testing utility with no guarantees
neos · Feb 7, 2024 · ef3e4d2 · ef3e4d2
2 parents df01c74 + 39cf8ad
commit ef3e4d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Neos.ContentRepository.TestSuite/Classes/Unit/NodeSubjectProvider.php b/Neos.ContentRepository.TestSuite/Classes/Unit/NodeSubjectProvider.php
@@ -47,7 +47,10 @@
  * The general provider class for node subjects.
  * Capable of creating all kinds of nodes to be used in unit tests.
  *
- * @api
+ * @internal this WIP helper is purely experimental and only to be used internally
+ *           behaviour or api may change at any time.
+ *           Generally It's advised to prefer behat testing over unit tests for complex cases,
+ *           like when interacting with the NodeType or the Subgraph or other parts of the CR.
  */
 final class NodeSubjectProvider
 {

diff --git a/Neos.Neos/Tests/Functional/Fusion/NodeHelperTest.php b/Neos.Neos/Tests/Functional/Fusion/NodeHelperTest.php
@@ -119,7 +119,7 @@ protected function buildView()
 
     protected function setUp(): void
     {
-        $this->markTestSkipped('Skipped until we find a better way to mock node read models (see https://github.com/neos/neos-development-collection/issues/4317)');
+        $this->markTestSkipped('Skipped. Either migrate to behat or find a better way to mock node read models. See https://github.com/neos/neos-development-collection/issues/4317');
         parent::setUp();
         $nodeSubjectProvider = new NodeSubjectProvider();