Skip to content

Commit

Permalink
!!! FEATURE: Drop twitter bootstrap dependency
Browse files Browse the repository at this point in the history
We only used it in one place and it’s basically not maintained anymore.
With this change the bootstrap library that is required for the media browser is moved to the media browser and therefore no other dependency is left.

This might be breaking for projects that use the bootstrap viewhelper or library and didn’t add they own dependency.

Resolves: #5408
  • Loading branch information
Sebobo committed Dec 19, 2024
1 parent aa96fc8 commit 92ba6cc
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Neos.Media.Browser/Configuration/Settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Neos:
bodyClasses: 'neos neos-module media-browser'
scripts:
- 'resource://Neos.Media.Browser/Public/Libraries/jquery/jquery-3.6.0.min.js'
- 'resource://Neos.Twitter.Bootstrap/Public/2/js/bootstrap.min.js'
- 'resource://Neos.Neos/Public/JavaScript/Main.min.js'
- 'resource://Neos.Media.Browser/Public/Libraries/bootstrap/bootstrap.min.js'
- 'resource://Neos.Media.Browser/Public/Libraries/bootstrap/bootstrap-components.js'
- 'resource://Neos.Media.Browser/Public/JavaScript/media-browser.js'
styles:
Expand Down Expand Up @@ -56,7 +56,7 @@ Neos:
additionalResources:
javaScripts:
- 'resource://Neos.Media.Browser/Public/Libraries/jquery/jquery-3.6.0.min.js'
- 'resource://Neos.Twitter.Bootstrap/Public/2/js/bootstrap.min.js'
- 'resource://Neos.Media.Browser/Public/Libraries/bootstrap/bootstrap.min.js'
- 'resource://Neos.Media.Browser/Public/Libraries/bootstrap/bootstrap-components.js'
styleSheets:
- 'resource://Neos.Media.Browser/Public/Styles/MediaBrowser.css'
Expand Down
Loading

0 comments on commit 92ba6cc

Please sign in to comment.