Add open options settings for test configs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration file and added some unit tests for that
Fixed the max heap size issue
This reverts commit baef582.
…untime Adding the ability to install neo4j labs plugins on container startup
This reverts commit 9c2f856.
After the changes in this PR, there is no hard requirement to have to install a valid certificate before starting Neo4j.
merged latest changes on the private branch.
… being run on a finished container, which errored.
Moved 4.0 scripts into the public repository
This is to enable the tests to run inside a docker container, even though they themselves spawn new containers. It was failing in our CI pipeline because of permission errors on mounted folders when testing mounting as non-root users.
…nstall-apoc-at-runtime"" This reverts commit 84425d9. Which re-enables plugin installation at runtime
Snyk has created this PR to upgrade org.slf4j:slf4j-api from 1.7.30 to 1.7.32. See this package in Maven Repository: https://mvnrepository.com/artifact/org.slf4j/slf4j-api/ See this project in Snyk: https://app.snyk.io/org/dimitris.larisis/project/20ca4914-4733-4c42-96d3-54ef1fb0e370?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade org.slf4j:slf4j-log4j12 from 1.7.30 to 1.7.32. See this package in Maven Repository: https://mvnrepository.com/artifact/org.slf4j/slf4j-log4j12/ See this project in Snyk: https://app.snyk.io/org/dimitris.larisis/project/20ca4914-4733-4c42-96d3-54ef1fb0e370?utm_source=github&utm_medium=referral&page=upgrade-pr
…lly fixed" This reverts commit cb3f98a.
The setting: dbms.memory.pagecache.size is about to change from `Setting<String>`` to `Setting<Long>`` and will therefore change slightly how the setting value is printed in the debug log. This changes a test assertion so that it accepts both variants of that debug log print.
… and not working atm
Temporary disable upgrade tests since upgrade is under update for 5.0 and not working atm
Change pagecache size debug log output assertion due to type change
jennyowen
requested changes
Dec 2, 2021
| @@ -1 +1,3 @@ | |||
| dbms.memory.heap.max_size=512m | |||
There was a problem hiding this comment.
you removed this important line
| @@ -240,6 +242,9 @@ void testCantWriteIfSecureEnabledAndNoPermissions_logs() throws IOException | |||
| void canMountAllTheThings_fileMounts(boolean asCurrentUser) throws Exception | |||
| { | |||
| Path testOutputFolder = HostFileSystemOperations.createTempFolder( "mount-everything-" ); | |||
| Path confFile = Paths.get( "src", "test", "resources", "confs", "MountConf.conf" ); | |||
| Files.copy( confFile, testOutputFolder.resolve( "neo4j.conf" ) ); | |||
|
|
|||
| try(GenericContainer container = setupBasicContainer( asCurrentUser, false )) | |||
| { | |||
| HostFileSystemOperations.createTempFolderAndMountAsVolume( container, "conf", "/conf", testOutputFolder ); | |||
There was a problem hiding this comment.
in this test it creates a folder /tmp/mount-everything-####/ then underneath on this line (L250) it creates a subfolder /tmp/mount-everything-####/conf which is where your conf file needs to go. At the moment you're not mounting it in a location where docker will see the conf.
| @@ -268,7 +273,7 @@ void canMountAllTheThings_namedVolumes(boolean asCurrentUser) throws Exception | |||
| { | |||
| container.withCreateContainerCmdModifier( | |||
| (Consumer<CreateContainerCmd>) cmd -> cmd.getHostConfig().withBinds( | |||
| Bind.parse("conf-"+id+":/conf"), | |||
| // Bind.parse("conf-"+id+":/conf"), // todo we need a set of open options, ask | |||
| causal_clustering.transaction_advertised_address=localhost:6060 | ||
|
|
||
| dbms.jvm.additional=--add-opens=java.base/java.nio=ALL-UNNAMED |
There was a problem hiding this comment.
why is it necessary to add these lines to all conf files?
There was a problem hiding this comment.
sorry i forgot to put some indication that its not ready oir review yet :) but more or less we moving options to required open modules to config instead of hardcoding them and without them you can't start neo4j
MishaDemianenko
force-pushed
the
5.0-open-options
branch
from
885682d
to
866089b
Compare
Previously some module options were hardcoded in neo4j. Now they are part of distributes neo4j config. As a result, if config gets lost or changed for test purposes we need to make sure we have a minimal set of options that will actually allow neo4j to be started.
MishaDemianenko
force-pushed
the
5.0-open-options
branch
from
866089b
to
f069fcb
Compare
|
@jennyowen i forced pushed some changes with some description as well. Also, there is one case with binds where I'm not sure how to adapt the test so will follow your suggestion there. So in short those 3 module options that now part of custom configs are required to start neo4j and without them container will not gonna start. As result if we have any test with custom config or config directory mapping we need to adapt those configs to have those options. Otherwise neo will fail on startupt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some module options were hardcoded in neo4j. Now they are part of distributes neo4j config. As a result, if config gets lost or changed for test purposes we need to make sure we have a minimal set of options that will actually allow neo4j to be started.