This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Fixes Problems with install & pytz - when pytz wasn't installed before... #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4. The problem was that the method
offset
in__init__.py
in called while install, because the moduleneotime.meta
ist imported. But before the install pytz isn't available. There were two possible fixes to that. First one was changing package structure, but i didn't wanted to do this, because this could cause breaks in other packages that depends on neotime.So I choosed the second solution, which was replacing the function when pytz isn't available, that should only happen while installation time. I added also an exception just in case there are errors with pytz outside of the installation time (e.g. uninstalled later by accident ...).
Hope you like my suggestion how to fix this.
Test are all passing as well: