Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BCTK LIB code into neo-express #342

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Move BCTK LIB code into neo-express #342

merged 4 commits into from
Nov 16, 2023

Conversation

Ashuaidehao
Copy link
Collaborator

@Jim8y
Copy link
Contributor

Jim8y commented Nov 16, 2023

Good to go @Ashuaidehao ?

@Ashuaidehao
Copy link
Collaborator Author

No more changes and ready for merge.

@Jim8y Jim8y merged commit b0bd037 into neo-project:master Nov 16, 2023
1 check passed
cschuchardt88
cschuchardt88 reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we updated the dependencies?

src/Directory.Build.props
</PropertyGroup>
<PropertyGroup>
<NeoVersion>3.6.0</NeoVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.2?

@Jim8y
Copy link
Contributor

Jim8y commented Nov 16, 2023

@Ashuaidehao test action is not triggered

@cschuchardt88
Copy link
Member

@Liaojinghui see #343

@Ashuaidehao Ashuaidehao deleted the import-bctk-project branch November 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move BCTK LIB code into neo-express repo
3 participants
@Ashuaidehao @Jim8y @cschuchardt88