fix: override code based defaults with explicit ones #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows that defaults that are set in attributes can override the ones that are read from the code. This fixes nelmio#2330
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
3 times, most recently
from
de11fd1
to
4451269
Compare
heiglandreas
changed the title
heiglandreas
changed the title
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
from
4451269
to
6419201
Compare
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
from
6419201
to
0a81850
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
==========================================
+ Coverage 89.46% 89.48% +0.01%
==========================================
Files 77 78 +1
Lines 2848 2890 +42
==========================================
+ Hits 2548 2586 +38
- Misses 300 304 +4 ☔ View full report in Codecov by Sentry. |
Seldaek
reviewed
Nov 6, 2024
heiglandreas
changed the title
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
from
7a499cb
to
006e643
Compare
This allows to fetch default values via reflection should they so far not have been set via other means. As that happens before the SymfonyConstraint handling, the required fields should be set as expected but should also take into account the default values set via Attributes or Annotations.
Two tests didn't handle the provided defaults properly, so I had to fix them to now also validate that the defaults are set appropriately
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
from
006e643
to
43eca97
Compare
DjordyKoert
requested changes
Nov 7, 2024
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
2 times, most recently
from
65cbd50
to
4e3fae1
Compare
As the library is set to be usable with PHP7.4 and the ReflectionProperty::has/getDefaultValue is only available for PHP8+ I needed to slightly refactor the class.
heiglandreas
force-pushed
the
override-code-defauls-with-explicitly-set-ones
branch
from
4e3fae1
to
6a2bffd
Compare
|
All problems should be addressed, the behaviour is almost the same as before. I had to change two tests where a default value was provided in the code that wasn't passed into the OpenAPI-spec previously but is passed in now. This could be considered a BC-break but I'd argue that it was broken in the first place and is therefore a Bug-Fix |
|
Thank you @heiglandreas ❤️ |
DjordyKoert
pushed a commit
that referenced
this pull request
Nov 7, 2024
## Description This change allows that defaults that are set in attributes can override the ones that are read from the code. This fixes #2330 Closes #2330 ## What type of PR is this? (check all applicable) - [x] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) (cherry picked from commit 84c7916)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows that defaults that are set in attributes can override the ones that are read from the code.
This fixes #2330
Closes #2330
What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)