fix: add missing trigger_deprecation calls to deprecated classes, methods #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicLuidold
commented
Apr 13, 2024
DominicLuidold
force-pushed
the
trigger-deprecation-calls
branch
from
1c83c97
to
ce09829
Compare
DominicLuidold
changed the title
DjordyKoert
requested changes
Apr 15, 2024
DominicLuidold
force-pushed
the
trigger-deprecation-calls
branch
from
ce09829
to
aa51929
Compare
DjordyKoert
requested changes
Apr 20, 2024
DominicLuidold
force-pushed
the
trigger-deprecation-calls
branch
from
342312d
to
3e7acf7
Compare
DominicLuidold
changed the title
DominicLuidold
force-pushed
the
trigger-deprecation-calls
branch
2 times, most recently
from
dc3701e
to
6f05acd
Compare
DominicLuidold
force-pushed
the
trigger-deprecation-calls
branch
from
6f05acd
to
b36a219
Compare
|
@DjordyKoert Is there any way we could merge this PR? I unfortunately always have to keep up with the latest version changes (and update the PHPUnit baseline) after each release to keep the right version number (see e.g. b36a219). 😅 |
# Conflicts: # CHANGELOG.md
…s' into fork/DominicLuidold/trigger-deprecation-calls
DjordyKoert
approved these changes
Oct 17, 2024
|
Sorry this took way too long than it should have to merge. Thank you for the time you spend on this @DominicLuidold ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing deprecation triggers to classes and methods that have been deprecated with a
@deprecatedannotation.