Skip to content

Commit

Permalink
chore: fix ci (#2343)
Browse files Browse the repository at this point in the history
| Q | A |

|---------------|---------------------------------------------------------------------------------------------------------------------------|
| Bug fix? | no |
| New feature? | no <!-- please update src/**/CHANGELOG.md files --> |
| Deprecations? | no <!-- please update UPGRADE-*.md and
src/**/CHANGELOG.md files --> |
| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need
to create an issue if none exists, explain below instead --> |

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the
documentation.

Additionally:
 - Always add tests and ensure they pass.
- For new features, provide some code snippets to help understand usage.
-->

Trying to get a green build again. Apparently it started failing
somewhen between August and September. Not checking in composer.lock is
risky, especially with tooling like PHPStan this can break any time :/

also: composer.json says php >= 7.4 but there are PHP 8+ features in the
code like named properties?
  • Loading branch information
herndlm authored Sep 24, 2024
1 parent 277fa17 commit 5eda246
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
1 change: 1 addition & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@
file that was distributed with this source code.
HEADER
],
'trailing_comma_in_multiline' => false,
])
->setFinder($finder);
11 changes: 0 additions & 11 deletions tests/Functional/ControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use OpenApi\Annotations as OA;
use Symfony\Component\HttpKernel\Attribute\MapRequestPayload;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelInterface;
use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;

/**
Expand All @@ -30,16 +29,6 @@ final class ControllerTest extends WebTestCase
protected function setUp(): void
{
$this->configurableContainerFactory = new ConfigurableContainerFactory();

static::createClient([], ['HTTP_HOST' => 'api.example.com']);
}

/**
* @param array<mixed> $options
*/
protected static function createKernel(array $options = []): KernelInterface
{
return new NelmioKernel([], null, []);
}

protected function getOpenApiDefinition(string $area = 'default'): OA\OpenApi
Expand Down

0 comments on commit 5eda246

Please sign in to comment.