-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings, update dependencies, Gradle and fix build #125
Conversation
Not sure what exactly was broken, but can you split this or remove the spelling/stylistic Java changes? Also, Java 11 is required IIRC, so it won't work with 1.8. |
The error can be seen for example on jitpack: https://jitpack.io/com/github/nelenkov/android-backup-extractor/56e986a/build.log
This comes from
Of course! I will do so in the evening and tell you when I am done.
Actually, that is true currently. However, this PR sets |
Done, see #126 for the style-related changes. This PR now only touches files outside the source root(s). |
Thanks! Did you test decryption with Java 8? I remember there was a reason I bumped it to 11. |
You're welcome!
|
I guess it could have been because 1.8 is deprecated and no longer supported. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gradlew publishToMavenLocal
did not work anymore, so this fixes it alongside other things