-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: give data researcher view access to other learners progress page #179
Open
tehreem-sadat
wants to merge
1
commit into
main
Choose a base branch
from
tehreem/oveeride_perm_for_progress_page_access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
"""Mock bridgekeeper permission map""" | ||
|
||
|
||
perms = {} |
3 changes: 3 additions & 0 deletions
3
test_utils/edx_platform_mocks_shared/lms/djangoapps/course_home_api/permissions.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"""Mocked course api permissions""" | ||
|
||
CAN_MASQUARADE_LEARNER_PROGRESS = 'fake_name' |
30 changes: 30 additions & 0 deletions
30
test_utils/edx_platform_mocks_shared/lms/djangoapps/courseware/rules.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
"""Mocked bridgekeepr lms rules""" | ||
|
||
|
||
class Rule: | ||
"""Mocked Base class for rules.""" | ||
def check(self, user, instance=None): | ||
"""Check if a user satisfies this rule.""" | ||
raise NotImplementedError() | ||
|
||
def __or__(self, other): | ||
return True | ||
|
||
|
||
class HasRolesRule(Rule): # pylint: disable=too-few-public-methods | ||
"""Mocked HasRolesRule""" | ||
def __init__(self, *roles): | ||
self.roles = roles | ||
|
||
def check(self, user=None, instance=None): | ||
return True | ||
|
||
|
||
class HasAccessRule(Rule): # pylint: disable=too-few-public-methods | ||
"""Mocked HasAccessRule""" | ||
|
||
def __init__(self, *roles): | ||
self.roles = roles | ||
|
||
def check(self, user=None, instance=None): | ||
return True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this line is needed. I'm presuming
perms
is a dictionary that we can set to without deleting, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this it was giving error that permission already existed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is explicitly prevented in
PermissionMap
. I searched and I found that there was no technical reason behind it. It's just to prevent accidental change of the permission. So, adel
statement is needed which will alarm reviewers as it did here!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thank you both!!