fix: enrollment api to remove exam scores for multiple courses #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehreem-sadat
force-pushed
the
tehreem/fix_enrollment_api_for_exam_scores
branch
from
afd4870 to
e069f9d
Compare
tehreem-sadat
force-pushed
the
tehreem/fix_enrollment_api_for_exam_scores
branch
from
e069f9d to
d65a8d5
Compare
shadinaif
requested changes
Dec 24, 2024
| if self.context.get('course_id'): | ||
| self.collect_grading_info() | ||
| else: | ||
| self.fields.pop('exam_scores', None) |
There was a problem hiding this comment.
fields is a cached property in DRF cached_property, which is not predictable at all. Please pop out exam_scores from requested_optional_field_tags. That will be the safest way to deal with it
Suggested change
| self.fields.pop('exam_scores', None) | |
| tags = self.context.get('requested_optional_field_tags'): | |
| if tags: | |
| self.context['requested_optional_field_tags'] = list(set(tags) - {'exam_scores'}) |
| (False, ['__all__']), | ||
| (False, ['csv_export']), | ||
| ]) | ||
| def test_learner_enrollment_serializer_exam_scores( |
There was a problem hiding this comment.
✅ great test, thank you!
tehreem-sadat
force-pushed
the
tehreem/fix_enrollment_api_for_exam_scores
branch
from
d65a8d5 to
256272a
Compare
tehreem-sadat
force-pushed
the
tehreem/fix_enrollment_api_for_exam_scores
branch
from
256272a to
9db37b1
Compare
tehreem-sadat
force-pushed
the
tehreem/fix_enrollment_api_for_exam_scores
branch
from
9db37b1 to
a07ef12
Compare
shadinaif
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #168