feat: handle fxcoded exception and return readable response #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadinaif
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thank you @tehreem-sadat , this is great!
I have one suggestion regarding the stand-alone function. On the other hand, if you're not comfortable with having the code inside FXViewRoleInfoMixin, then you can create another mixing that FXViewRoleInfoMixin inherits. So, anything that inherits FXViewRoleInfoMixin will have the new mixing automatically. I'll leave it to you to decide
Comment on lines
68
to
75
| def fx_exception_handler(exc: Exception) -> Response | None: | ||
| """Handle exception and return response with error details""" | ||
| if isinstance(exc, FXCodedException): | ||
| return Response( | ||
| error_details_to_dictionary(reason=str(exc)), | ||
| status=status.HTTP_400_BAD_REQUEST | ||
| ) | ||
| return None |
There was a problem hiding this comment.
no need for a stand-alone function in my opinion. Please move the code to handle_exception method
tehreem-sadat
force-pushed
the
tehreem/handle_fxcoded_exception
branch
from
4153873 to
fc6f92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #161