fix: global roles do not have access to views #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehreem-sadat
approved these changes
Nov 18, 2024
shadinaif
force-pushed
the
shadinaif/fix-global-roles-do-not-have-access
branch
from
dc94e80 to
d170c25
Compare
Scenario: the user has one role `support`. The view allows `support` roles to access it. Before the fix: the user is not allowed to access the view After the fix: the user is allowed to access the view
shadinaif
force-pushed
the
shadinaif/fix-global-roles-do-not-have-access
branch
from
d170c25 to
627036b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: global roles do not have access to views
Scenario: the user has one role
supportBefore the fix: the user is not allowed to access the view
After the fix: the user is allowed to access the view