feat: removable annotations on pagination #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadinaif
force-pushed
the
shadinaif/removable-annotations
branch
from
bd75d8b to
370d68b
Compare
shadinaif
force-pushed
the
shadinaif/removable-annotations
branch
from
c8817d2 to
2994f33
Compare
shadinaif
commented
Nov 16, 2024
| if active_filter is not None: | ||
| q_set = q_set.filter(course_is_active=active_filter) | ||
| update_removable_annotations(q_set, not_removable=['course_is_active']) |
There was a problem hiding this comment.
if the annotation is being used in a filter, then it's not a removable one!
shadinaif
force-pushed
the
shadinaif/removable-annotations
branch
3 times, most recently
from
468f0f9 to
36c65cf
Compare
shadinaif
force-pushed
the
shadinaif/removable-annotations
branch
from
36c65cf to
1c16381
Compare
tehreem-sadat
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Countif removing the annotation is needed. UseSubqueryinstead