Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove staff access in courses for catalog views #37

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: remove staff access in courses for catalog views #37

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4f1e45
feat: remove staff access for catalog views
johanseto Sep 5, 2024
0edd142
fix: update tests for staff in see_in_catalog
johanseto Sep 5, 2024
35bce58
feat: add flag to manage staff see in catalog
johanseto Sep 12, 2024
bd7c87e
Revert "fix: update tests for staff in see_in_catalog"
johanseto Sep 12, 2024
a29df93
feat: keep custom test with default beahviour
johanseto Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lms/djangoapps/courseware/access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,10 @@ def can_see_in_catalog():
"""
return (
_has_catalog_visibility(courselike, CATALOG_VISIBILITY_CATALOG_AND_ABOUT)
or _has_staff_access_to_descriptor(user, courselike, courselike.id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing this, could you add a feature flag inside the _has_staff_access_to_descriptor method that allows to keep standard and custom behavior ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I could add a feature flag, but I only want to change can_see_in_catalog. I don't want to affect many other places where the staff could have permission.
Do you agree to add the feature flag only here?

or (
_has_staff_access_to_descriptor(user, courselike, courselike.id)
and getattr(settings, "STAFF_CAN_SEE_IN_CATALOG", True)
)
)

@function_trace('can_see_about_page')
Expand Down
Loading