feat: this changes the current phone number regex to allow the plus s… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymbol in the first character
johanseto
reviewed
Jul 15, 2024
| @@ -53,7 +53,7 @@ class PhoneNumberSerializer(serializers.BaseSerializer): # lint-amnesty, pylint | |||
|
|
|||
| def to_internal_value(self, data): | |||
| """Remove all non numeric characters in phone number""" | |||
There was a problem hiding this comment.
Could you update the docstring. + is not numeric
andrey-canon
force-pushed
the
and/modify_phone_number_regex
branch
from
c50c432 to
469a776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modifies the current serializer regex that removes all characters that are not numbers, to allow the plus symbol at the beginning.
Testing instructions