fix(languages/java): avoid infinite stack overflow for FindSymbol

nedpals · Mar 13, 2024 · 57ce740 · 57ce740
1 parent bd33cc1
commit 57ce740
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/languages/java/language.go b/languages/java/language.go
@@ -51,6 +51,15 @@ func (an *javaAnalyzer) FallbackSymbol() lib.Symbol {
 }
 
 func (an *javaAnalyzer) FindSymbol(name string) lib.Symbol {
+	return an.findSymbolWithRetries(name, 0)
+}
+
+func (an *javaAnalyzer) findSymbolWithRetries(name string, retry int) lib.Symbol {
+	if retry > 3 {
+		// do not retry more than 3 times or it will cause stack overflow
+		return lib.UnresolvedSymbol
+	}
+
 	sym, ok := builtinTypesStore.FindByName(name)
 	if ok {
 		return sym
@@ -86,7 +95,7 @@ func (an *javaAnalyzer) FindSymbol(name string) lib.Symbol {
 	}
 
 	// if parsed, find the symbol again
-	return an.FindSymbol(name)
+	return an.findSymbolWithRetries(name, retry+1)
 }
 
 func (an *javaAnalyzer) markAsUnresolved(name string) lib.Symbol {