Add logging to determine which recommendation module was selected, wh…

…en recommendations are advising version
nebula-plugins · Dec 3, 2015 · 6a0615e · 6a0615e
1 parent bc91e4d
commit 6a0615e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/main/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPlugin.java b/src/main/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPlugin.java
@@ -8,13 +8,17 @@
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
 import org.gradle.api.artifacts.*;
+import org.gradle.api.logging.Logger;
+import org.gradle.api.logging.Logging;
 import org.gradle.api.plugins.ExtraPropertiesExtension;
 import org.gradle.api.plugins.JavaPlugin;
 
 import java.util.ArrayList;
 import java.util.List;
 
 public class DependencyRecommendationsPlugin implements Plugin<Project> {
+    private Logger logger = Logging.getLogger(DependencyRecommendationsPlugin.class);
+
     @Override
     public void apply(final Project project) {
         project.getExtensions().create("dependencyRecommendations", RecommendationProviderContainer.class, project);
@@ -57,6 +61,7 @@ public void execute(DependencyResolveDetails details) {
 
                                 String version = getRecommendedVersionRecursive(project, requested);
                                 if (version != null && firstOrderDepsWithoutVersions.contains(coord)) {
+                                    logger.info("Recommending version " + version + " for dependency " + requested.getGroup() + ":" + requested.getName());
                                     details.useVersion(version);
                                 }
                             }

diff --git a/...roovy/netflix/nebula/dependency/recommender/provider/FileBasedRecommendationProvider.java b/...roovy/netflix/nebula/dependency/recommender/provider/FileBasedRecommendationProvider.java
@@ -4,7 +4,10 @@
 import org.gradle.api.Project;
 import org.gradle.api.artifacts.Configuration;
 import org.gradle.api.artifacts.ExternalModuleDependency;
+import org.gradle.api.artifacts.ResolvedArtifact;
 import org.gradle.api.internal.artifacts.dependencies.DefaultExternalModuleDependency;
+import org.gradle.api.logging.Logger;
+import org.gradle.api.logging.Logging;
 import org.gradle.internal.typeconversion.NotationConvertResult;
 
 import java.io.File;
@@ -15,6 +18,7 @@
 
 public abstract class FileBasedRecommendationProvider extends AbstractRecommendationProvider {
     protected Project project;
+    private Logger logger = Logging.getLogger(FileBasedRecommendationProvider.class);
 
     protected InputStreamProvider inputProvider = new InputStreamProvider() {
         @Override
@@ -98,7 +102,11 @@ public InputStream getInputStream() throws Exception {
                 // create a temporary configuration to resolve the file
                 Configuration conf = project.getConfigurations().detachedConfiguration(
                         project.getDependencies().create(dependencyNotation));
-                return new FileInputStream(conf.resolve().iterator().next());
+
+                ResolvedArtifact artifactId = conf.getResolvedConfiguration().getResolvedArtifacts().iterator().next();
+                logger.info("Selected recommendation source " + artifactId.getId() + ", you requested " + dependencyNotation);
+
+                return new FileInputStream(artifactId.getFile());
             }
         };
         return inputProvider;