Fix Gradle 8.12 deprecation warning #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We should not reference project from task execution phase
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 18, 2024
|
@rpalcolea do you have the bandwidth to review this one? |
|
oh this is nice! thanks for doing it. I was planning to go through some deprecations after the holiday season! will release in a bit |
|
https://github.com/nebula-plugins/gradle-ospackage-plugin/releases/tag/v11.10.1 should go out soon :) |
|
alright, this is now available @breskeby https://plugins.gradle.org/plugin/com.netflix.nebula.ospackage ! thanks again! |
|
Wow that was quick! highly appreciated! |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 23, 2024
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 23, 2024
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 24, 2024
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 27, 2024
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing gradle 8.12 rc 1 & 2 we realised they introduced a few more deprecations and that broke our build.
This fixes the deprecation warnings we saw. We use jitpack to test this in our build here: elastic/elasticsearch#118683