Skip to content

Commit

Permalink
change isSubmodule to submodule flag name to better play with jackson…
Browse files Browse the repository at this point in the history
… expectations at reading side
  • Loading branch information
chali committed Nov 2, 2021
1 parent 17fa5c9 commit b2c6600
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class PathAwareDiffReportGenerator : DiffReportGenerator {
"repeated" to true
},
if (dependencyPathElement.isSubmodule())
"isSubmodule" to true
"submodule" to true
else
"version" to dependencyPathElement.selected.moduleVersion()
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ class PathAwareDependencyDiffSpec extends IntegrationTestKitSpec {
def allConfigurations = lockdiff[0]
def directDependencies = allConfigurations["differentPaths"]
def common = directDependencies.find { it.dependency == "test:common"}
common.isSubmodule == true
common.submodule == true
def foo = common.children.find { it.dependency == "test.example:foo" }
foo.version == "2.0.1"
foo.change.description == "requested"
Expand Down Expand Up @@ -845,7 +845,7 @@ class PathAwareDependencyDiffSpec extends IntegrationTestKitSpec {
def allConfigurations = lockdiff[0]
def directDependencies = allConfigurations["differentPaths"]
def common = directDependencies.find { it.dependency == "test:common"}
common.isSubmodule == true
common.submodule == true
common.change.description == "new local submodule"
common.change.type == "NEW"
}
Expand Down

0 comments on commit b2c6600

Please sign in to comment.