fix(resharding): do not fail flat storage resharding if account id does not belong to parent #12675
Conversation
Trisfald
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12675 +/- ##
==========================================
+ Coverage 70.50% 70.52% +0.01%
==========================================
Files 845 845
Lines 172258 172308 +50
Branches 172258 172308 +50
==========================================
+ Hits 121452 121514 +62
+ Misses 45710 45698 -12
Partials 5096 5096
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| error!(target: "resharding", ?new_shard_uid, ?left_child_shard, ?right_child_shard, ?shard_layout, ?account_id, err_msg); | ||
| return Err(Error::ReshardingError(err_msg.to_string())); | ||
| let err_msg = "account id doesn't map to any child shard! - skipping it"; | ||
| warn!(target: "resharding", ?new_shard_uid, ?left_child_shard, ?right_child_shard, ?shard_layout, ?account_id, err_msg); |
There was a problem hiding this comment.
Maybe let's use debug_assert, ideally something that would not silently pass in forknet testing.
There was a problem hiding this comment.
The purpose of this PR is to unblock forknet testing though :(
There was a problem hiding this comment.
I agree with both, can you add a todo to change it to debug_assert once we fix the root cause?
There was a problem hiding this comment.
I will add the todo in a minor PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
If
account_idof a key does not map to any child (and thus does not belong to the parent in the first place), just log a warning and avoid failing the entire operation.