feat: parallel partial witness handling in the partial witness actor #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12656 +/- ##
=======================================
Coverage 70.55% 70.56%
=======================================
Files 847 847
Lines 172685 172777 +92
Branches 172685 172777 +92
=======================================
+ Hits 121845 121922 +77
- Misses 45736 45757 +21
+ Partials 5104 5098 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stedfn
changed the title
stedfn
changed the title
stedfn
commented
Jan 3, 2025
Comment on lines
-412
to
+415
| )? { | ||
| self.forward_state_witness_part(partial_witness)?; | ||
| } | ||
| self.partial_witness_spawner.spawn("handle_partial_encoded_state_witness", move || { | ||
| // Validate the partial encoded state witness and forward the part to all the chunk validators. | ||
| match validate_partial_encoded_state_witness( | ||
| epoch_manager.as_ref(), | ||
| &partial_witness, | ||
| &signer, | ||
| runtime_adapter.store(), | ||
| ) { | ||
| Ok(true) => { | ||
| network_adapter.send(PeerManagerMessageRequest::NetworkRequests( | ||
| NetworkRequests::PartialEncodedStateWitnessForward( | ||
| target_chunk_validators, | ||
| partial_witness, | ||
| ), | ||
| )); | ||
| } |
There was a problem hiding this comment.
@shreyan-gupta it seems that we do not store the first partial witness received from the chunk producer and rebuild the state witness from the forwarded ones. While storing 1 partial witness faster won't make much of a difference, I was wandering if this was intended or if I missed something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR unblocks the main thread of the
PartialWitnessActorby detaching the handling of the partial witnesses to separate threads.This results in a considerable reduction in the distribution latency of the state witness:
The image originates from a forknet experiment with 50 nodes, with each state witness artificially padded to reach a size of 30 MB.