41: Refactor assertSame() to be a top-level function #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Success! - Legacy Sample screenshot test resultsView build for commit b5b1ff0 |
✅ Success! - Flix Sample screenshot test resultsView build for commit b5b1ff0 |
DanielJette
force-pushed
the
41-capture-method
branch
from
dbbf67b to
ea08a92
Compare
|
I will rebase this over the weekend |
DanielJette
force-pushed
the
41-internal-state
branch
from
99d3414 to
9c687c0
Compare
AndroidTestifyBot
approved these changes
Oct 9, 2023
DanielJette
force-pushed
the
41-internal-state
branch
from
9c687c0 to
7a5671c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
Follow-up to #169
Resolves #41
This PR completes the refactoring of
ScreenshotRuleinto several modules. Specifically, this PR introduces a top-level function version ofassertSame(). With this, additional screenshot methods can easily be built.Scope of Impact and Testing instructions
Changed
ScreenshotRule.getScreenshotInstrumentationAnnotation()is now a top-level function.Collection<Annotation>.getAnnotation()renamed toCollection<Annotation>.findAnnotation().getScreenshotAnnotationName()changed fromdev.testify.internal.extensionstodev.testify.annotation.ScreenshotRule.initializeView()is now a top-level function.EspressoHelpernow extendsScreenshotLifecycleandbeforeScreenshot()has been replaced withafterInitializeView()Added
isRunningOnUiThread()added as a top-level function.outputFileName()added as an extension method forContext.AssertionStateScreenshotLifecycleHostassertSame()is now available as a top-level function, decoupled fromScreenshotRuleRemoved
open fun ScreenshotRule.generateHighContrastDiff(baselineBitmap: Bitmap, currentBitmap: Bitmap)has been removed. Useclass HighContrastDiffdirectly.ScreenshotRule.applyViewModifications()has been removed. UseTestifyConfiguration.applyViewModificationsMainThread()instead.Notice