148: Refactor output path into Destination #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielJette
force-pushed
the
148-custom-output-path
branch
from
d20188e to
b02dcaa
Compare
Library/src/main/java/dev/testify/output/DataDirectoryDestination.kt
Outdated
Show resolved
Hide resolved
DanielJette
force-pushed
the
148-custom-output-path
branch
from
b02dcaa to
ff59f02
Compare
DanielJette
force-pushed
the
148-custom-output-path
branch
from
ff59f02 to
34c1da7
Compare
✅ Success! - Legacy Sample screenshot test resultsView build for commit 4b07565 |
✅ Success! - Flix Sample screenshot test resultsView build for commit 4b07565 |
DanielJette
requested review from
olegosipenko,
AndroidTestifyBot and
a team
and removed request for
olegosipenko
olegosipenko
approved these changes
Sep 5, 2023
| useSdCard = useSdCard(InstrumentationRegistry.getArguments()), | ||
| path = getOutputDirectoryPath(this).absolutePath | ||
| ) | ||
| private fun Destination.assureScreenshotDirectory(context: Context) { |
There was a problem hiding this comment.
shouldn't this method be part of Destination class? 🤔
There was a problem hiding this comment.
This is a convenience wrapper around Destination.assureDestination() which checks the return value of assureDestination() and throws an exception if it's false.
AndroidTestifyBot
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
Prerequisite for #148
How have you achieved it?
This PR introduces two core changes:
Destinationinterface. This allows Testify to implement various alternative file output locations. The existingdata/dataandsdcardoutput destinations have been ported to the new interface. This allows for future destinations to be easily supported in the future. This change is backwards compatible.build.gradleare now visible to the Library code. So, advanced configuration options can now be set in thebuild.gradlefile and used by any Library code. In this PR, I have used this feature to pass theuseSdCardconfiguration option to the Library and also to pass the current Gradle module name.📔 In addition, a small refactoring to
ErrorCausewas made to support the two new exceptions addedScope of Impact and Testing instructions
ScreenshotTestandReporternow use theDestinationinterface. This should not affect users of Testify, but does impact developers and those who wish to subclass Testify classes.Notice